sophfee / impulse-issues

report problems you have with impulse
1 stars 0 forks source link

Dispatch Calls Out Wrong Tagline for Supervisor BSLs #100

Closed Miraak11 closed 1 year ago

Miraak11 commented 2 years ago

Describe the bug When a Civil Protection supervisor with a properly chosen tagline is killed, the Dispatch announcement of their death will read their tagline as "HERO-1" regardless of what their actual tagline is. This also happens with OTA supervisor deaths; previously their deaths would be announced using the CP-equivalent of their tagline (ex. SCAR-0 would become VICTOR-0), but now they are all announced as "HERO-1".

To reproduce Steps to reproduce the behaviour:

  1. Join a Combine team, either CP or OTA
  2. Kill a supervisory unit/wait for one to die with a tagline that is not "HERO-1"
  3. Listen closely for their death announcement via the radio dispatch
  4. Notice that unit's tagline is still read out as "HERO-1"

Expected behaviour That dispatch will read out the appropriate tagline upon a supervisor's death.

Screenshots If applicable, add screenshots to help explain your problem. N/A impulse version (press F1 in the bottom right): 1.10.10 Lua error If applicable, post the error here in full. N/A Additional context Add any other context about the problem here. I recall nick saying something about a change about how supervisor taglines are stored serverside, and the issue only started after this change, so their might be a correlation.

sophfee commented 1 year ago

Fixing this rn