search

sophiajt / new-nu-parser

23 stars 10 forks source link

Adds benchmarks #26

Closed FilipAndersson245 closed 4 months ago

FilipAndersson245 commented 5 months ago

As one of the reason for the rewrite is performance, I Think its good to have a track record of the performance somewhere, this is two simple benchmark added in this PR, one that create a deeply nested record, a second that construct a small table with multiple different types. I initially wanted to add the current env.nu and config.nu but it the parser panics when I tried to parse them.

fdncred commented 5 months ago

Agreed. I think it's good to start somewhere with benchmarks. What would be even better would be if the results are stored somewhere in a csv or nuon file so we could look at the changes over time.

FilipAndersson245 commented 5 months ago

Agreed. I think it's good to start somewhere with benchmarks. What would be even better would be if the results are stored somewhere in a csv or nuon file so we could look at the changes over time.

Yes, Divan is currently working creating a file based format when that is completed I think we should setup something that continuously track the performance, I would love if we could have a regression test in performance on PR in nutshell for example simular to how Rustlang does it but maybe on a smaller scale.