sophiakoulen / minishell

A simplified bash-like shell, with pipes, redirections and variable expansion.
4 stars 1 forks source link

testing report looks good #142

Closed znichola closed 1 year ago

znichola commented 1 year ago

@t-h2o kindly did some tests on the docker version of 927f4f2741ae19568dbc11ef96d17338d7404752

Full list of commands are return is quite long with a variety of tests, see list here : commands_tested.txt

looks like only some leaks with readline, full report : valgrind-out.txt

==3659== 32 bytes in 1 blocks are definitely lost in loss record 34 of 102
==3659==    at 0x4848899: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==3659==    by 0x4899BAC: xmalloc (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x48907C2: rl_add_undo (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4890F4C: rl_insert_text (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4892411: _rl_insert_char (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4897154: rl_insert (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4877E97: _rl_dispatch_subseq (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4878CC9: readline_internal_char (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x4881D14: readline (in /usr/lib/x86_64-linux-gnu/libreadline.so.8.1)
==3659==    by 0x10A76E: read_input (main.c:65)
==3659==    by 0x10A7BA: interactive_shell (main.c:85)
==3659==    by 0x10A665: main (main.c:32)
==3659== 
==3659== LEAK SUMMARY:
==3659==    definitely lost: 32 bytes in 1 blocks
==3659==    indirectly lost: 0 bytes in 0 blocks
==3659==      possibly lost: 0 bytes in 0 blocks
==3659==    still reachable: 214,984 bytes in 412 blocks
==3659==         suppressed: 0 bytes in 0 blocks
==3659== Reachable blocks (those to which a pointer was found) are not shown.
==3659== To see them, rerun with: --leak-check=full --show-leak-kinds=all