search

sophie-glk / bang

A firefox addon which adds bangs (known from duckduckgo) to various search engines.
MIT License
46 stars 5 forks source link

[Bug?] Bangs are case sensitive #17

Closed TorMechia closed 3 years ago

TorMechia commented 3 years ago

I apologize in advance if this is an end-user issue (i.e. I'm a moron).

Bang shortcuts in lowercase work as intended... image image

But do a normal search when in uppercase. image image

Is this intended?

babastienne commented 3 years ago

This extension offers a a better implementation of the bangs than just the bang feature of DDG, because it allow the user to define himself its own bangs. Therefore, considering that !BANG should be the same that !bang is quite touchy because a user could have define two differents bangs in his own configuration.

Still, I'm pretty sure it would be possible to implement something : When a user search something with a bang that contains upppercase letters and that bang does not exists in the custom configuration of the user, then the bang is automatically converted in lowercase before running the search.

sophie-glk commented 3 years ago

This should be an easy one line fix

sophie-glk commented 3 years ago

In the latest development version this should be fixed