search

sophiien / pe

0 stars 0 forks source link

Allows for extremely long module code #4

Open sophiien opened 2 years ago

sophiien commented 2 years ago

Describe the bug

Allows for adding of module codes tag with extremely long names and unable to see the full module code being displayed in the list.

To Reproduce

Steps to reproduce the behavior:

  1. Type "tag m/cs21409093483840293840928349283480293840238409283048234809238409283409283402830498230948209342834"
  2. Allows for successful edit even though the module code may not be valid.

Expected behaviour

Show error message to indicate length constraints on module code and/or allow for UI to display full module code .

Screenshots

Screenshot 2022-04-16 at 2.34.48 PM.png

Desktop (please complete the following information):

OS: macOS 11.6

nus-se-bot commented 2 years ago

Team's Response

We accept this as a feature flaw instead. The reason being the command is working as intended however we can agree that this can lead to issues for the intended user group and necessary checks should be there to ensure such issues don't happen.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]