search

sophiien / pe

0 stars 0 forks source link

Invalid tags for add command #5

Open sophiien opened 2 years ago

sophiien commented 2 years ago

Describe the bug

After adding an invalid additional i/INTERNSHIP tag to the add command, add command still works successfully even though it is not in the UG.

To Reproduce

Steps to reproduce the behavior:

  1. Type "add n/person p/9123 e/hello@gmail.com a/office i/shopee"
  2. Successfully adds person with address as "office i/shopee" rather than just office

Expected behaviour

Show error message to indicate that incorrect tags are used for the add command

Screenshots

Screenshot 2022-04-16 at 2.40.44 PM.png

Desktop (please complete the following information):

OS: macOS 11.6

nus-pe-bot commented 2 years ago

Team's Response

The add command does not look out for the "i/" prefix as a delimiter. The add command only looks out for "n/", "p/", "a/" and "e/" as delimiters, which corresponds to the name, phone number, address and email respectively.

We do not allow the creation of tags through the add command, else it defeats the purpose for our tag command.

image.png

There could also be addresses that contains a slash, such as "Office Building A #04-01/02", where the place occupies more than 1 unit in a building.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]