search

sophornsna / r-labs

Automatically exported from code.google.com/p/r-labs
0 stars 0 forks source link

Wrong line selection: +29 line after real line. #41

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Showing C source file from SVN repository
2. Select pencil to show code review window.

Code review window appears but the line is original line #+29

Code Review version : 0.3.1
Redmine version: 1.0.2

See attached file (JPG)

Original issue reported on code.google.com by jwalker...@gmail.com on 19 Oct 2010 at 4:53

Attachments:

GoogleCodeExporter commented 8 years ago 
Is someone listening at this issues tracker?

Ivan

Original comment by jwalker...@gmail.com on 15 Dec 2010 at 7:36

GoogleCodeExporter commented 8 years ago 
Sorry for my late answer.

I've tried to reproduce it but I couldn't.
Does it happen with every file in your repository?

Original comment by haru.ii.a9i1e on 22 Dec 2010 at 3:21

GoogleCodeExporter commented 8 years ago 
Hi,

Yes, it happens with every file - at least with the files that I tried with. 
I also installed test instance of Redmine, with no any other plugins, just code 
review. Then I started it by 'ruby script\server -e production'. The error 
appeared. Sometimes +30, +29, +31. This does not appear with diffs. It appears 
only with files.

I use Subversion.

Ivan

Original comment by jwalker...@gmail.com on 24 Dec 2010 at 1:48

GoogleCodeExporter commented 8 years ago 
Thanks.
I have one more question.
What browser do you use?

Original comment by haru.ii.a9i1e on 25 Dec 2010 at 10:26

GoogleCodeExporter commented 8 years ago 
I use Firefox 3.6.x

Original comment by jwalker...@gmail.com on 25 Dec 2010 at 11:12

GoogleCodeExporter commented 8 years ago 
Hi,

I tried now from different PC, via VPN, far way from my office. I just wondered 
how would it behave in different browsers. I was surprised that the error did 
not appeared in any one of MS IE, Firefox, Google Chrome. I'm sorry I cannot 
try from my laptop, to see if the error will keep showing until Monday evening 
(it's Christmas now in our country). Then I will post again. Anyway, if the 
error has gone, I'll be happy, nevertheless not knowing why ....

Ivan

Original comment by jwalker...@gmail.com on 25 Dec 2010 at 11:30

GoogleCodeExporter commented 8 years ago 
Hi,

Now I can prove it (on my laptop):
Firefox 3.6.13: adds +23
Internet Explorer 8 : works as expected (OK)

I have installed lots of plugins in Firefox and may be someone of them makes 
the wrong thing..., don't know...

Well, redmine_codereview is OK, thank you for this plugin, it is very helpful.

Ivan

Original comment by jwalker...@gmail.com on 27 Dec 2010 at 6:55