search

sor1n / Jewelrycraft

Minecraft mod
8 stars 4 forks source link

Stack overflow on SMP with feather effect #37

Open LemADEC opened 8 years ago

LemADEC commented 8 years ago

Using Jewelrycraft2-1.7.10-1.1.4

When a player in creative,wearing a ring with feather effect, gets attacked, a stack overflow occurs and crash the server:

       at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:646)
        at darkknight.jewelrycraft.effects.EffectFeather.onEntityAttackedCacellable(EffectFeather.java:69)
        at darkknight.jewelrycraft.item.ItemBaseJewelry.onEntityAttackedCacellable(ItemBaseJewelry.java:109)
        at darkknight.jewelrycraft.events.EntityEventHandler.onEntityAttacked(EntityEventHandler.java:199)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler_174_EntityEventHandler_onEntityAttacked_LivingAttackEvent.invoke(.dynamic)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
        at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
        at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:302)
        at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:850)
        at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1158)
        at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:646)
        at darkknight.jewelrycraft.effects.EffectFeather.onEntityAttackedCacellable(EffectFeather.java:69)
        at darkknight.jewelrycraft.item.ItemBaseJewelry.onEntityAttackedCacellable(ItemBaseJewelry.java:109)
        at darkknight.jewelrycraft.events.EntityEventHandler.onEntityAttacked(EntityEventHandler.java:199)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler_174_EntityEventHandler_onEntityAttacked_LivingAttackEvent.invoke(.dynamic)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
        at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
        at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:302)
        at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:850)
        at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1158)
        at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:646)
        at darkknight.jewelrycraft.effects.EffectFeather.onEntityAttackedCacellable(EffectFeather.java:69)
        at darkknight.jewelrycraft.item.ItemBaseJewelry.onEntityAttackedCacellable(ItemBaseJewelry.java:109)
        at darkknight.jewelrycraft.events.EntityEventHandler.onEntityAttacked(EntityEventHandler.java:199)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler_174_EntityEventHandler_onEntityAttacked_LivingAttackEvent.invoke(.dynamic)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
        at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
        at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:302)
        at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:850)
        at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1158)
        at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:646)
        at darkknight.jewelrycraft.effects.EffectFeather.onEntityAttackedCacellable(EffectFeather.java:69)
        at darkknight.jewelrycraft.item.ItemBaseJewelry.onEntityAttackedCacellable(ItemBaseJewelry.java:109)
        at darkknight.jewelrycraft.events.EntityEventHandler.onEntityAttacked(EntityEventHandler.java:199)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler_174_EntityEventHandler_onEntityAttacked_LivingAttackEvent.invoke(.dynamic)
        at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
        at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
        at net.minecraftforge.common.ForgeHooks.onLivingAttack(ForgeHooks.java:302)
        at net.minecraft.entity.EntityLivingBase.func_70097_a(EntityLivingBase.java:850)
        at net.minecraft.entity.player.EntityPlayer.func_70097_a(EntityPlayer.java:1158)
        at net.minecraft.entity.player.EntityPlayerMP.func_70097_a(EntityPlayerMP.java:646)
        at darkknight.jewelrycraft.effects.EffectFeather.onEntityAttackedCacellable(EffectFeather.java:69)
        at darkknight.jewelrycraft.item.ItemBaseJewelry.onEntityAttackedCacellable(ItemBaseJewelry.java:109)
        at darkknight.jewelrycraft.events.EntityEventHandler.onEntityAttacked(EntityEventHandler.java:199)

Removing that specific ring fixed the issue. We didn't try in survival mode.

sor1n commented 8 years ago

Thank you for letting me know. There are plenty of things that do not work in SMP, unfortunately if I ever continue working on the mod, it will probably be for 1.8.9, but it's good to know what the bugs are, for the future.

LemADEC commented 8 years ago

Any other known issues in SMP?

sor1n commented 8 years ago

Yeah, issues with curses not being synced. Curse points not being synced sometimes or being weirdly added. Most things don't work as intended because the mod didn't start as complicated first, so SMP was never my priority.