[Tech]: Make changes into LP Fee information according new returned from quote - Githubissues

sora-xor / sora-android

Android client application to interact with SORA, a supranational world economic system with a decentralized and democratic governance.

Other

18 stars 11 forks source link

[Tech]: Make changes into LP Fee information according new returned from quote #405

Closed ra9mls closed 8 months ago

ra9mls commented 8 months ago

Problem statement

We have a task which will change the data of quote - https://github.com/sora-xor/sora2-network/issues/925 Design task - https://app.zenhub.com/workspaces/sora-wallet---development-6529439e287e980cb41b583b/issues/zh/22 Now we have XOR token only in LP Fee but we will have more tokens on fees for swaps. For example for swap XST-XSTUSD we will have fee in XST. For XOR-XSTUSD we will have 2 tokens, XOR and XST. For XSTUSD-DAI it can be 3 tokens like XOR, XSTUSD, XST.

Description

No response

Acceptance Criteria

App shows LP Fee by the asset which it receives from quote RPC.

Definition of Done

User sees LP Fee by the asset which it receives from quote RPC
App can work with old and new type of RPC

Requirements

No response

arvifox commented 8 months ago

Trezeguet1 commented 8 months ago

Verified on 3.8.4.0 Soralution Beta version.

telegram-cloud-photo-size-2-5449677599107306639-y

telegram-cloud-photo-size-2-5449677599107306640-y