sora-xor / sora-card-ios

Designing a Better World Through Decentralized Technologies
Apache License 2.0
1 stars 0 forks source link

[Bug]: [SORA Card] iOS - There is no pending status for the Sora card banner #108

Closed Trezeguet1 closed 5 months ago

Trezeguet1 commented 9 months ago

Preconditions

Complete sign up Sora card flow

telegram-cloud-photo-size-2-5323774008669360878-y

Steps to reproduce

  1. Approve documents in Admin panel
  2. Check SORA Card banner status -> Log out
  3. Login another number for Sora card
  4. Reject documents in Admin panel
  5. Check SORA Card banner status
  6. Repeat reject flow 4 times

Actual behavior

There is no pending status for the Sora card banner. Either zero is shown or the text get SORA card when you re-login to the app.

image

telegram-cloud-photo-size-2-5323665981651933452-y

Expected behavior

Shimmers and pending status should be displayed while the SORA card status is changing.

https://www.figma.com/file/Rqm3Y2XAq3pg0zfProoaqe/%F0%9F%8E%A8-SORA-Wallet-(In-Design)?type=design&node-id=4168-3842&mode=design&t=5NtR4eVjKPF4IzHI-0

Screenshot 2023-10-30 at 20 36 20

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

Sora Dev 1.0 (236) for iOS version

telegram-cloud-photo-size-2-5323665981651933330-y

2bogd commented 9 months ago

@spitsynval looks like we have inconsistency in design for case when no balance to display need some clarifications

Снимок экрана 2023-11-10 в 15 02 24 Снимок экрана 2023-11-10 в 15 02 50
2bogd commented 9 months ago

builds: https://jenkins.soramitsu.co.jp/job/sora/job/sora-ios/view/tags/job/3.7.1/

Trezeguet1 commented 9 months ago

Verified on 1.0. (259) develop version.

We need add the case when no balance to display.

Screenshot 2023-11-27 at 13 25 33
2bogd commented 7 months ago

Small updates

Screen 1 is for case when IBAN is not exist yet
Screen 2 is for case when IBAN is exist but having network problem for loading it

1 Снимок экрана 2023-11-10 в 15 02 24 2 Снимок экрана 2023-11-10 в 15 02 50

@spitsynval

Trezeguet1 commented 5 months ago

Verified on 3.8.3 (21) version.