search

sora-xor / sora-card-ios

Designing a Better World Through Decentralized Technologies
Apache License 2.0
1 stars 0 forks source link

[Bug]: iOS - Incorrect Card issuance screen for Not enough XOR case #115

Closed Trezeguet1 closed 9 months ago

Trezeguet1 commented 9 months ago

Preconditions

SORA Card banner appears

Steps to reproduce

  1. Import wallet without XOR
  2. Tan SORA Card banner

Actual behavior

Incorrect Card issuance screen for Not enough XOR case. There is no Log out option looks like as in design.

telegram-cloud-photo-size-2-5361589945875156536-y

Expected behavior

There should be correct Card issuance screen for Not enough XOR case as in design. The Log out option should be presented.

telegram-cloud-photo-size-2-5361589945875156589-y

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

Design: https://www.figma.com/file/5kaHWqH73Ekez7RVOpH36g/%E2%9C%85-SORA-Wallet-(on-Prod)?type=design&node-id=13169-6595&mode=design&t=cBNst6TTaRGO8LqR-4

2bogd commented 9 months ago

duplication of https://github.com/sora-xor/sora-card-ios/issues/109

Trezeguet1 commented 9 months ago

Verified on 1.0. (259) develop version. The issue is still repro.

telegram-cloud-photo-size-2-5407120228460122664-y

telegram-cloud-photo-size-2-5407120228460122665-y

Trezeguet1 commented 9 months ago

Merge fix to develop from builds: https://jenkins.soramitsu.co.jp/job/sora/job/sora-ios/view/tags/job/3.7.1/