search

sora-xor / sora-ios

Designing a Better World Through Decentralized Technologies
Other
10 stars 2 forks source link

[Bug]: iOS - List of bugs for fixes on version 3.8.0 #336

Closed Trezeguet1 closed 8 months ago

Trezeguet1 commented 11 months ago

Preconditions

Screenshot 2023-12-05 at 12 49 54

Steps to reproduce

Fresh install 3.8.0 (8) version

Actual behavior

  1. It takes a long time for the data to arrive when the shimmers are loading and after a crash happened, I think since we have a large list of tokens now sorted by TVL.
Screenshot 2023-12-05 at 12 49 15
  1. When there are no active farms in Stake your pool share for extra rewards - there is no APR text for the case on iOS.

telegram-cloud-photo-size-2-5436145836489824675-y

  1. Missing APR text for iOS in Active Farms.

  2. Make translations before release to fill in the lines in localize.

telegram-cloud-photo-size-2-5436145836489824666-y

  1. Rewards are calculated incorrectly for iOS - on the web as well as for Android 100 DEO, we need to add rounding as well.

  2. The drop does not light up with a green indicator, for example on this pair XSTUSD-ETH Pool when there is already liquidity - on Android the green indicator.

telegram-cloud-photo-size-2-5433923190914142217-y

  1. Your pool share is not rounded on iOS- in design and on android 0.05 the value is rounded to hundredths.

  2. There should not be a rounding by design to the bottom bar on the list of pools and tokens.

telegram-cloud-photo-size-2-5433923190914142191-x

  1. The name of the assets buttons and the swap button differs from the design and from the Android version, there should be a wallet tab and a palkaswap button everywhere.

telegram-cloud-photo-size-2-5436145836489824602-x

Expected behavior

Test the List of bugs for fixes on version 3.8.0.

Environment

{"label"=>"Development"}

OS version

17.1.2

Additional context

Soralution 3.8.0 (8) version

Trezeguet1 commented 11 months ago
  1. Fixed
  2. Fixed
  3. Fixed
  4. Localize is not implemeted
  5. We need to add rounding as well like on Android

telegram-cloud-photo-size-2-5438428628787515237-y

  1. Fixed
  2. Fixed
  3. Fixed
  4. Fixed
Trezeguet1 commented 11 months ago

Please add rounding for rewards value in Active farms on Pool details screen, as well like on Android. @ShlyapkinIN

Trezeguet1 commented 11 months ago

We can't verify the version 1.0 (265) develop since there is no farming there and can only be checked in Soralution and Prod.

Trezeguet1 commented 10 months ago

Verified on 3.8.1(8) Soralution version.

Trezeguet1 commented 9 months ago

  1. Still no rounding for rewards value in Active farms.

  2. It takes a long time for the data to arrive when the shimmers are loading and after a crash happened.

Verified on 3.8.1 (19) Soralution version.

image
Trezeguet1 commented 9 months ago

Fixes will be included in the next Soralution build and there will be a purely formatting edit.

Trezeguet1 commented 8 months ago

Verified on 3.8.4(7) TF version.

telegram-cloud-photo-size-2-5465342044915488315-y