search

sorainsm / library-of-lighting-models

Study of light modeling as a physics problem, with the purpose of implementing of a family of lighting models through a library.
0 stars 1 forks source link

System VnV: Review Create Scene Tests #22

Open sorainsm opened 4 years ago

sorainsm commented 4 years ago

Hi Peter, my System VnV is ready for review (71f977d04f1b2d24b20706e1098ab039910c9426). Could you please take a look at the Create Scene(5.1.1 - Create Scene) Tests (5.1.2.) to see whether these belong in the System VnV?

The intention behind these services is how the system corrects itself when it receives incomplete input and the ok to use the default scene from the user. I'm torn because on one hand the user is giving input to the system (the incomplete data, and the ok to use the default scene) - however everything else is internal to the system to it almost seems like it ought to be a unit or integration test.

Your opinion would be invaluable!

peter-michalski commented 4 years ago

Hi Sasha, this is an interesting question so I would like to get @smiths opinion on this.

I believe that the 5.1.1 tests could be placed into either the system or the unit VnV. One of the deciding factors will be how you decide to code this part of the system and if the required code is split across multiple modules. If it is, then it should definitely be in the System VnV. If it is not split, it could still be part of the system VnV, as you say the user is giving input to the system.

5.1.2 look like they would use several modules of the program, so it would be easy to justify them as system tests.