search

sorainsm / library-of-lighting-models

Study of light modeling as a physics problem, with the purpose of implementing of a family of lighting models through a library.
0 stars 1 forks source link

Primary Reviewer Module to Implement #54

Closed peter-michalski closed 4 years ago

peter-michalski commented 4 years ago

Hi @sorainsm, please let me know what you would like me to implement.

sorainsm commented 4 years ago

Hi Peter,

Sorry for the late reply. Could you please implement Vector module in a language of your choosing (whichever you know best)?

I have talked with @smiths and most of the modules that I have documented are built into the system that I'm using, meaning that the only parts to implement would require learning the Unity Shader Language. As such, we agreed that you could implement the Vector module in whatever language you feel comfortable so as to get feedback on how well the module guide explains the module.

peter-michalski commented 4 years ago

I have added a C# implementation in 7747a863fa6cf6ca84b3179b405465bf841bb913.

Vector appears to be a class. I was unsure how to proceed with the start() function.

smiths commented 4 years ago

I haven't done a detailed comparison between the spec and the code, but I'm encouraged by what I see. This seems like a successful experiment. @sorainsm, it isn't required for CAS 741, but when you review the work of @peter-michalski, I would be curious to hear about any differences you observe between the spec and the implementation.