search

sorainsm / library-of-lighting-models

Study of light modeling as a physics problem, with the purpose of implementing of a family of lighting models through a library.
0 stars 1 forks source link

CA Review: Data Definitions #6

Closed sorainsm closed 4 years ago

sorainsm commented 4 years ago

Please take a close look at the Data Definitions. I am unsure whether DD8-10 should be Data Definitions or whether I should have listed DD8 as a Theoretical Model, with DD9-10 being general definitions or instance models of this.

image image

smiths commented 4 years ago

@sorainsm, you should assign this issue to someone, even if your intention is to self-assign the issue. Maybe you are intending to assign it to your primary or secondary reviewer?

sorainsm commented 4 years ago

@smiths I'm waiting on my primary and secondary to accept the invite as collaborators. I will assign this to myself for now, and reassign once they accept.

smiths commented 4 years ago

Makes sense. :smile:

peter-michalski commented 4 years ago

Sorry I started creating issues before accepting the invite. Just noticed this now. I'll take a look!

peter-michalski commented 4 years ago

@sorainsm I think that your current placement is correct. As far as I can tell DD9 is not derived from DD8, it only uses a variable from it. I am assuming that the relationship is the same for DD10