soraxas / echo360

Commandline tool for automated downloads of echo360 videos hosted by university
https://cs.tinyiu.com/echo360
MIT License
262 stars 51 forks source link

Pool not defined error #24

Closed hsk274 closed 4 years ago

hsk274 commented 4 years ago

Hi,

I was able to make the log-in work, but I'm getting this error message when I'm trying to download. Any idea what went wrong?

Traceback (most recent call last): File "echo360.py", line 7, in sys.exit(main()) File "/Users/DarkKnight/Downloads/echo360-master/echo360/main.py", line 259, in main downloader.download_all() File "/Users/DarkKnight/Downloads/echo360-master/echo360/downloader.py", line 235, in download_all if video.download(self._output_dir, filename): File "/Users/DarkKnight/Downloads/echo360-master/echo360/videos.py", line 260, in download audio_file = self._download_url_to_dir(urljoin( File "/Users/DarkKnight/Downloads/echo360-master/echo360/videos.py", line 148, in _download_url_to_dir echo360_downloader = Downloader(pool_size, File "/Users/DarkKnight/Downloads/echo360-master/echo360/hls_downloader.py", line 43, in init self.pool = Pool(pool_size) NameError: name 'Pool' is not defined

soraxas commented 4 years ago

Hi @hsk274 thanks for your message. Can you download the repository again and see if it works now?

hsk274 commented 4 years ago

Thank you for your help. I downloaded the repository and the error was resolved. However, the download seems to be stuck with no progress update. Can you let me know if I am doing something wrong?

The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.
Bruces-MBP:~ DarkKnight$ /Users/DarkKnight/Downloads/echo360-master\ 2/run.sh https://echo360.org/section/2dc3a3c3-e80a-4eea-8cca-2701951c9fe8/home --interactive
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ImportError: No module named virtualenv
> Echo360 Cloud platform detected
> This implies setup_credential, and using web_driver
>> Please login with your SSO details and type continue when logged in.
-----------------------------------------------------------------
 >> After you finished logging into echo360 cloud, the window should be automatically redirected and continued. If it got stuck, please contact the author :)
>> I'm gonna assume you are responsible enough to had finished logged in by now ;)
>> Retrieving echo360 Course Info...  0/10 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  5/10 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  10/10 videos Done!
============================================================
    Course: [[UNTITLED]]
      Total videos to download: 1 out of 10
============================================================

------------------------------------------------------------
Downloading "2020-04-30 - Lecture 10 [04.30.20_B8378_001_Value Investing with Legends_545PM_Santos]"
  > Downloading audio:
hsk274 commented 4 years ago

I tried a different lecture, and it seems like the script is for some reason failing to detect the videos

>> After you finished logging into echo360 cloud, the window should be automatically redirected and continued. If it got stuck, please contact the author :)
>> I'm gonna assume you are responsible enough to had finished logged in by now ;)
>> Retrieving echo360 Course Info...  0/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  1/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  2/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  3/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  4/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  5/6 videos No audio+video m3u8 files found! Skipping...
This can either be (i) Credential failure? (ii) Logic error in the script. (iii) This lecture only provides audio?
This script is hard-coded to download audio+video. If this is your intended behaviour, please contact the author.
>> Retrieving echo360 Course Info...  6/6 videos Done!
============================================================
    Course: [[UNTITLED]]
      Total videos to download: 6 out of 6
============================================================
>> Skipping Lecture '2019-03-04 - Lecture 6 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.
>> Skipping Lecture '2019-02-25 - Lecture 5 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.
>> Skipping Lecture '2019-02-18 - Lecture 4 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.
>> Skipping Lecture '2019-02-11 - Lecture 3 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.
>> Skipping Lecture '2019-02-04 - Lecture 2 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.
>> Skipping Lecture '2019-02-01 - Lecture 1 [8144-1 Introduction to Programming in R]' as it says it does not contain any video.

=================================================================
    Course: [[UNTITLED]]
=================================================================
    Successfully downloaded:
soraxas commented 4 years ago

It's hard to say what's going on by this output. Can you run with --debug flag and send me the resulting log file (echo360Downloader.log) which should be in the same folder via email if you don't mind? Thanks

hsk274 commented 4 years ago

Hi Oscar,

I am sending you the debug log. Let me know if it is what you are looking for. Thank you so much for the help. I really appreciate it.

From: Oscar Tin Lai notifications@github.com Reply-To: soraxas/echo360 reply@reply.github.com Date: Saturday, June 20, 2020 at 8:42 AM To: soraxas/echo360 echo360@noreply.github.com Cc: hsk274 hsk274@gmail.com, Mention mention@noreply.github.com Subject: Re: [soraxas/echo360] Pool not defined error (#24)

It's hard to say what's going on by this output. Can you run with --debug flag and send me the resulting log file (echo360Downloader.log) which should be in the same folder via email if you don't mind? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/soraxas/echo360/issues/24#issuecomment-646989755, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOA4GAMIFYNFURNZ2Q5LPS3RXSVC5ANCNFSM4OC5H5HA.

soraxas commented 4 years ago

I don't see anything, did you attached it to an email for the Github email notification? You can send it to oscar AT tinyiu DOT com directly

hsk274 commented 4 years ago

Just sent you an email. Thank you.

soraxas commented 4 years ago

Hi @hsk274 it didn't work because the data structure was a bit different than what I had encountered before. I've added some new parsing logic, you can try to see the latest update works for you

hsk274 commented 4 years ago

Unfortunately, it still didn't work. I've emailed you the new debug log. Thank you.

soraxas commented 4 years ago

Hi sorry I made a mistake of using an iterator method on a list, as I couldn't verify the code with my setup.

The issue should be fixed now

hsk274 commented 4 years ago

That worked! Thank you.