Outdated chromedriver

[fengyuan213]

Hello, I am tring to download a lectures through SSO, the webdriver said "RESPONSE InitSession unknown error: cannot find Chrome binary" in webdriver_service.log, I have the error fixed and logd in by redownloading the lastest compaticable chromedriver and put it into bin/chromedriver.exe .it worked, Is it possible maybe update the download address of chrome driver? Here is the link:https://chromedriver.chromium.org/downloads

[soraxas]

Does it works if you edit the target version in the following file? https://github.com/soraxas/echo360/blob/master/echo360/binary_downloader/chromedriver.py

I think the chrome driver might be dependent on the installed chrome, so fixing on latest version might also break earlier chrome version.

I would be happy to accept PR if it is possible to determine the current installed chrome and download the corresponding necessary chrome driver

[jbatesy]

The code should consider installed version & pick appropriately, the geckodriver install is also affected by this. It also didn't check all locations on my $PATH as I already had geckodriver on $PATH.

Will likely pick this up and make a PR.

[soraxas]

Sure, sounds good

On 1 March 2023 20:47:09 jbatesy @.***> wrote:

The code should consider installed version & pick appropriately, the geckodriver install is also affected by this. It also didn't check all locations on my $PATH as I already had geckodriver on $PATH. Will likely pick this up and make a PR. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[soraxas]

closes by #76