search

soraxas / echo360

Commandline tool for automated downloads of echo360 videos hosted by university
https://cs.tinyiu.com/echo360
MIT License
261 stars 51 forks source link

Bump selenium to 4.16.0. #78

Closed TheRootOf3 closed 8 months ago

TheRootOf3 commented 8 months ago

While maintaining support for older versions of ChromDrivers, would it be possible to lift the upper version restriction for selenium in requiremenets.txt? The current 4.1.3 is incompatible with Chome v120.

soraxas commented 8 months ago

Yep, this was original set to deal with https://github.com/SeleniumHQ/selenium/blob/58122b261a5f5406da8e5252c9ab54c464da7aa8/py/CHANGES#L79

However, it should now actually be possible via changes in d2de7875cfc607bb5d4c44c02f63a4a765a04e83, with https://github.com/soraxas/echo360/blob/8c07786f56f3dc57f17652470de6c746f0ec0091/echo360/downloader.py#L172-L174 checking and handling newer version of selenium.

Feel free to test if newer version works for you, and if so, send a PR to bump selenium version

TheRootOf3 commented 8 months ago

Thanks, tested with selenium 4.16.0 - works well! Created PR: #79

Happy new year! 🥳

soraxas commented 8 months ago

Happy new year!