search

sorccu / docker-adb

Dockerfile and instructions for ADB.
Other
200 stars 74 forks source link

adbkey and adbkey.pub #5

Closed alexislg2 closed 8 years ago

alexislg2 commented 8 years ago

There's a mistake in both the Dockerfile and the documentation: The path of the adbkeys is /root/.android/ not /.android/

Do you want a PR?

sorccu commented 8 years ago

That was not the case before, however the behavior may have changed. Could you verify your findings by installing adb yourself, running once, and then checking where it placed the files?

alexislg2 commented 8 years ago

Well I spent last hour trying to figure out why my adbkeys where not working. and then I found that there is another directory /root/.android/ that contains other adbkeys. After mounting my keys into that directory it worked perfectly

But that makes sense. Those keys should be stored in the ~/.android directory so that corresponds to /root/.android

sorccu commented 8 years ago

It does make sense, however that's not how it worked before, so I'm just wondering where and when it changed. I can't spend much time on this, so if you can verify that your findings are correct and submit a PR with a Dockerfile that builds, that would be great.

alexislg2 commented 8 years ago

OK I will do that. I did verify my findings

sorccu commented 8 years ago

(As a side note I feel that the image is too large, mainly because of the difficulty of downloading the ADB binary. It would be great if someone could take a look into it. I probably can't do it for at least the next month or so.)

alexislg2 commented 8 years ago

can't we just apt-get install android-tools-adb android-tools-fastboot ? But maybel that will result in same image size. Other solution would be to build from source but again that might give a big image in the end

sorccu commented 8 years ago

No, those are horribly out of date. Presumably precisely because they're annoying to build by themselves.

On Friday, 1 July 2016, ALEXIS LE GOFF notifications@github.com wrote:

can't we just apt-get install android-tools-adb android-tools-fastboot ? But maybel that will result in same image size. Other solution would be to build from source but again that might give a big image in the end

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sorccu/docker-adb/issues/5#issuecomment-229918888, or mute the thread https://github.com/notifications/unsubscribe/AAB-_ZmH6WtyEdwoGxMvaJ5wr7TpQK3xks5qRPJ2gaJpZM4JC9rt .

sorccu commented 8 years ago

Sorry, I got a motivation boost from your feedback, had a pretty good idea on how to do the download more efficiently, and just went ahead with a full redesign. I fixed this issue during the redesign.