sorccu / r2d2-redis

MIT License
101 stars 42 forks source link

r2d2_redis_patch – Crate that should have been a PR? #13

Closed dvdplm closed 6 years ago

dvdplm commented 6 years ago

Hi, I ran into some trouble today using this crate and ended up trying https://github.com/nottxy/r2d2-redis instead and it worked. I think the only change (https://github.com/nottxy/r2d2-redis/commit/a87fd7b81872508c637bc626ed9070cad594debd) is a mere r2d2 version upgrade and could perhaps have been a PR here instead. The issues feature on that repo is disabled so I'm opening one here instead.

badboy commented 6 years ago

It needs a bit more, see #14

sorccu commented 6 years ago

Yeah, we generally update the crate as long as someone actually tells us when something breaks with newer versions. Thanks for letting us know @dvdplm and good work @badboy.