search

sorccu / r2d2-redis

MIT License
101 stars 42 forks source link

Reexport `r2d2` and `redis` dependencies #16

Closed Turbo87 closed 6 years ago

Turbo87 commented 6 years ago

Resolves https://github.com/sorccu/r2d2-redis/issues/15

/cc @sorccu

sorccu commented 6 years ago

I think this is a good idea overall but not sure whether the example should be updated as well. In other words I'm not sure which method we should recommend by default.

sorccu commented 6 years ago

@badboy Thoughts?

badboy commented 6 years ago

r2d2-mysql exports it, r2d2-postgres exports it.

So the exporting part seems reasonable to do. I think we should also then switch over to changing the documentation. People will then use it and we get less issue reports because of version mismatches. IMO this can be done in a follow-up PR.

Turbo87 commented 6 years ago

@badboy the docs update is already part of this PR. should I extract it to a separate PR?

badboy commented 6 years ago

That's on me for not actually checking the PR content. Of course it's fine keeping the doc change in here as well.

Approval from my side!