Closed Turbo87 closed 6 years ago
I think this is a good idea overall but not sure whether the example should be updated as well. In other words I'm not sure which method we should recommend by default.
@badboy Thoughts?
r2d2-mysql exports it, r2d2-postgres exports it.
So the exporting part seems reasonable to do. I think we should also then switch over to changing the documentation. People will then use it and we get less issue reports because of version mismatches. IMO this can be done in a follow-up PR.
@badboy the docs update is already part of this PR. should I extract it to a separate PR?
That's on me for not actually checking the PR content. Of course it's fine keeping the doc change in here as well.
Approval from my side!
Resolves https://github.com/sorccu/r2d2-redis/issues/15
/cc @sorccu