Closed sorccu closed 5 years ago
Hmm, I suppose this only happens on cargo 1.37.0 and later:
https://github.com/rust-lang/cargo/commit/34307c6122eb1b9368c70f3b3ca3900ef08ad6b8
I've decided to not fight cargo
even though this is just a library and therefore should not include Cargo.lock
.
@badboy I tried releasing a new minor version after merging the latest pull requests, but keep getting the following error:
This doesn't make sense to me as:
Cargo.lock
is in included in.gitignore
git status --ignored
confirms thatCargo.lock
is ignoredI also tried
rustup run stable cargo release minor
but it had the same behavior.I checked
cargo-release
's source code and there doesn't seem to be any way to pass--allow-dirty
tocargo publish
.An easy way to quickly check if the issue is still there is to run
cargo package
:In the end, the issue seems to boil down to:
https://github.com/rust-lang/cargo/blob/49fbf52fd517906a2229ca83d468971c1113b015/src/cargo/core/package.rs#L226-L228
Essentially, since we include examples (which are binaries), it seems that we should perhaps NOT ignore our
Cargo.lock
.How were you able to release earlier?