search

sorear / smetamath-rs

sorear's Metamath system engine - version 3 Rust
Apache License 2.0
22 stars 6 forks source link

random style changes, take 2 #20

Closed digama0 closed 8 years ago

digama0 commented 8 years ago

These commits are cleaned up from the thread #19. In particular, there are no revert commits, and the commit diffs are sufficiently disjoint that you can review them all in one go with the full diff. Notably, the "objectification" commits were removed, as well as anything else you rejected.

sorear commented 8 years ago

Thank you. LGTM.

(spent a fair amount of time benchmarking this, the total runtime difference is statistically insignificant but the very last commit increases dynamic instruction count by 0.5%. No idea why.)