search

soren121 / lightblog

PHP/SQLite blogging platform
GNU General Public License v3.0
2 stars 0 forks source link

Broken HTML on main page when a long post starts with two paragraphs. #35

Closed soren121 closed 9 years ago

soren121 commented 9 years ago

From parasy...@gmail.com on March 21, 2012 04:12:16

Create a new post with two paragraphs. Keep the first fairly short, and the second a bit longer. Something like this works well to illustrate:

    Hello world. This is a test. Just a simple test.

    This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test. This is a test. Just a simple test.

When the post is truncated for display on the main page, the longer second paragraph will contain a premature </div> tag, breaking the HTML.

Original issue: http://code.google.com/p/lightblog/issues/detail?id=35

soren121 commented 9 years ago

From doodle62 on March 23, 2012 13:36:25

I can't reproduce that bug. Can you take a screenshot, or setup a testing site to show me?

soren121 commented 9 years ago

From parasy...@gmail.com on April 05, 2012 19:44:14

Have a look at: http://blog.kodewerx.org/

soren121 commented 9 years ago

From doodle62 on April 05, 2012 20:22:09

My guess would be that it's a quirk with the WYSIWYG editor, nicEdit. It has many problems, and the developer isn't actively supporting it anymore. I've been trying to switch for a while, and my choices are now down to: CLEditor, TinyMCE, or coding a new editor from scratch.

nicEdit does so much wrong because it outputs bad HTML and then tries to clean it with regular expressions. CLEditor doesn't use paragraph tags. TinyMCE goes against the philosophy of LightBlog (and its own name) because it is anything but tiny. But I guess if I want a good WYSIWYG editor, I'll have to sacrifice something. I can't write anything in JavaScript, let alone a WYSIWYG editor. It is the most finicky language I've ever used, probably due to the browsers.

While I try to get another WYSIWYG editor integrated, I'll look into how posts are truncated.

Status: Accepted
Labels: -Milestone-0.9.3 Milestone-0.9.4

soren121 commented 9 years ago

From doodle62 on April 06, 2012 10:32:32

Looks like it does have to do with the post truncator. Not sure what it's doing wrong. I'll just have to replace it with something else.

soren121 commented 9 years ago

From doodle62 on April 06, 2012 11:03:31

Should be fixed in SVN r518 . Just replace Sources/Template.php with the new version in r518 , and it should fix the problem.

Status: Fixed
Labels: -Milestone-0.9.4 Milestone-0.9.3

soren121 commented 9 years ago

From parasy...@gmail.com on April 07, 2012 13:42:01

Works a treat! Thank you.