search

sorenlouv / backport

A simple CLI tool that automates the process of backporting commits on a GitHub repo
https://github.com/sqren/backport/blob/main/docs/config-file-options.md
Apache License 2.0
247 stars 60 forks source link

Add signoff option #336

Closed iliapolo closed 2 years ago

iliapolo commented 2 years ago

Apologies for jumping the gun here but since this is a fairly simple addition, I went ahead and created a PR. Hope this makes it in :)

Fixes https://github.com/sqren/backport/issues/335

sorenlouv commented 2 years ago

This is great! Thanks for doing this! Will run the CI and do some manual tests and merge today or sometime this week.

iliapolo commented 2 years ago

@sqren I fixed the failing test with this commit. Any idea why the checks aren't being re-triggered?

sorenlouv commented 2 years ago

@sqren I fixed the failing test with this commit. Any idea why the checks aren't being re-triggered?

No idea. Until I pushed your commit didn't even show up as part of this PR. I'm tempted to blame this on a Github bug but not sure. Either way, it works now.

sorenlouv commented 2 years ago

I've released this in v8.4.0. Please try it out and lmk if it works as expected. Thank you for the contribution! 🎉

iliapolo commented 2 years ago

@sqren Thanks for releasing this so quickly!

I'm trying to test this out in our repo. I'd like to use your GitHub Action to do automatic backports based on labels, but I don't think the latest version of the action uses the new version of the CLI.

Do you need to cut a release for the action as well? is there some workaround I can employ to control the version of backport being used in the action?

Thanks!

iliapolo commented 2 years ago

@sqren I managed to workaround this by directly using the CLI instead of the GitHub action.

If you want to take a look: https://github.com/cdk8s-team/cdk8s-plus/pull/655

I do however think its worth either auto-upgrading and releasing the action with the latest CLI version, or allow for some escape hatching.

Have a look at projen, which can help you with automatic dependency upgrades (and lots more)

Thanks anyway!

sorenlouv commented 2 years ago

Thanks for the heads up. Will bump the version in the GitHub action asap and set up some automation around dependency updates

sorenlouv commented 2 years ago

@iliapolo I updated the dependencies for backport-github-action. It follows the same versioning as the underlying backport tool so you can update to 8.4.0 to get the signoff option:

- name: Backport Action
  uses: sqren/backport-github-action@v8.4.0
iliapolo commented 2 years ago

Thanks @sqren - I think I'll stick to directly using the CLI though, at least until the action is automatically upgraded.

I love that basically all of the functionality is in the CLI - so the action is not strictly necessary :)

iliapolo commented 2 years ago

Btw I tested the singoff option and it works as expected

sorenlouv commented 2 years ago

Perfect, thanks for the feedback. I'll look into automatically updating the github action when the cli tool is updated.