search

sorentwo / readthis

:newspaper: Pooled active support compliant caching with redis
MIT License
506 stars 40 forks source link

0.8.0 not compatible with activesupport 4.2.4? #11

Closed bcm closed 9 years ago

bcm commented 9 years ago

I just updated to readthis 0.8.0 and activesupport 4.2.4 and am now getting an exception when precompiling assets for my rails app:

remote:        Running: rake assets:precompile
remote:        rake aborted!
remote:        ArgumentError: wrong number of arguments (2 for 0..1)
remote:        /tmp/build_97046e5596bfb10b8c3b0e5c337b2a9a/vendor/bundle/ruby/2.2.0/gems/readthis-0.8.0/lib/readthis/cache.rb:41:in `initialize'
remote:        /tmp/build_97046e5596bfb10b8c3b0e5c337b2a9a/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.4/lib/active_support/cache.rb:60:in `new'
remote:        /tmp/build_97046e5596bfb10b8c3b0e5c337b2a9a/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.4/lib/active_support/cache.rb:60:in `lookup_store'
remote:        /tmp/build_97046e5596bfb10b8c3b0e5c337b2a9a/vendor/bundle/ruby/2.2.0/gems/railties-4.2.4/lib/rails/application/bootstrap.rb:76:in `block in <module:Bootstrap>'
...

ruby 2.2, deploying to heroku. please let me know if you need any more info to reproduce.

sorentwo commented 9 years ago

Thanks for reporting your trouble. The signature changed in v0.8.0 to only accept an options hash rather than a URL and options. The change was made to support passing additional redis options through (important for setting up sentinel, etc).

There are more details in the changelog, and the documentation was updated in the readme.

Sorry for the confusion.

bcm commented 9 years ago

hm, I see. I guess that's the peril of assuming a 0.7 to 0.8 upgrade will be backwards compatible, and then reading the stack trace and blaming active support without looking closely through the changelog. thanks for pointing out the change.