search

sorentwo / readthis

:newspaper: Pooled active support compliant caching with redis
MIT License
504 stars 40 forks source link

Add a `keep_alive` option to fetch. #42

Closed reillybeacom closed 8 years ago

reillybeacom commented 8 years ago

Just a suggestion. No tests added, sorry.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.7%) to 99.304% when pulling 290fd6e089cad19b1d2b011ef2b8253ec5258fac on reillybeacom:master into 8356933ddffa9c3f262d9a9aaf54f33284622826 on sorentwo:master.

sorentwo commented 8 years ago

I like the idea behind this feature, but I think refresh [fits the Redis terminology[(http://redis.io/commands/expire#refreshing-expires) better than keep_alive. Let me know if you're interested in pushing on this to add tests and refactor a little bit.

sorentwo commented 8 years ago

Thanks for the suggestion! I took this and ran with it, https://github.com/sorentwo/readthis/compare/ebc8774...master