search

sorentwo / readthis

:newspaper: Pooled active support compliant caching with redis
MIT License
504 stars 40 forks source link

duplicate object in passthrough dump to prevent mutation in entity compose #44

Closed kagux closed 8 years ago

kagux commented 8 years ago

storing a string using passthrough with fetch returns mutated string with flags if value wasn't stored before

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8ee0ef4846ffbba9de362d37c245837b96431b30 on kagux:fix/fetching_with_passthrough into 553d45273d179ece53c723cb9b4a827a0c378d5b on sorentwo:master.

sorentwo commented 8 years ago

Thanks for finding this, it's an important fix for anybody using passthrough and fetch together. I've left a few stylistic comments. Please make those tiny changes and I'd be happy to merge this in.

You can ignore the CI failure, it's pulling in ActiveSupport 5 now Rails dropped support for Ruby < 2.2.

kagux commented 8 years ago

I've updated PR

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 242e5337e4faa793576377288bdb4243a64ebbce on kagux:fix/fetching_with_passthrough into 553d45273d179ece53c723cb9b4a827a0c378d5b on sorentwo:master.

sorentwo commented 8 years ago

Merged locally to verify the CI fix without forcing you to rebase, and also to adhere to proper git commit formatting. Closed with 62a775b

sorentwo commented 8 years ago

Thank you so much for this. Moving on to your next one now!