search

sorentwo / readthis

:newspaper: Pooled active support compliant caching with redis
MIT License
506 stars 40 forks source link

Upgrade to redis-rb 4.0 #56

Closed tak1n closed 7 years ago

tak1n commented 7 years ago

I updated the gemspec to point to ~> 4.0. The only breakage I saw was in cache_spec on how to access the low level client.

https://github.com/redis/redis-rb/blob/master/CHANGELOG.md#40

Added support for CLIENT commands. The lower-level client can be accessed via Redis#_client.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling eec4a0d0cd45f6e71cda04b5802a3ccd12c0c440 on tak1n:master into 82575d145ff93be728367c5762e9aa8a8655fef9 on sorentwo:master.

sorentwo commented 7 years ago

I took a look at the changelog for redis-rb and it doesn't look like the 4.0 change has any significant changes, but it does have a couple of breaking changes. The breaking changes don't have any effect on readthis, but could be an issue for application code.

Let's change the requirement to allow both 3.X and 4.X.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1fe820e71ba171006b9ec488ff36db43a32c56fd on tak1n:master into 82575d145ff93be728367c5762e9aa8a8655fef9 on sorentwo:master.

sorentwo commented 7 years ago

@tak1n Thanks!

morgoth commented 7 years ago

@sorentwo Can we have a release with this change?

sorentwo commented 7 years ago

@morgoth thanks for the prompt, released as v2.1.0