search

sorentwo / readthis

:newspaper: Pooled active support compliant caching with redis
MIT License
504 stars 40 forks source link

add Errno::EADDRNOTAVAIL to redis connect errors #61

Closed spk closed 5 years ago

spk commented 6 years ago

Reported on redis-rb https://github.com/redis/redis-rb/pull/744 Until its merged we can rescue low-level exception Errno::EADDRNOTAVAIL (Address not available) Cheers

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7eab7f7bd6d51194ca9c4570d9c1e9415a929e17 on spk:connect-errors into 2bdf79329f2de437664ed74b2152b329f1b20704 on sorentwo:master.

sorentwo commented 6 years ago

Thanks for the patch and the link to the redis-rb change. I'm considering whether we should rescue from anything other than Redis::BaseError inside the library. Clearly this is a real issue you've ran into in an application, but perhaps it is best handled at the application level.

spk commented 6 years ago

I don't know if we should rescue from anything look dangerous. Yes but it will be painful because we would have to rescue every Rails.cache calls ...

spk commented 5 years ago

This has been merged on redis-rb closing thanks for considering it