sorgerlab / CancerBrowser

HMS LINCS Cancer Browser
5 stars 3 forks source link

If threshold matches value, bar is displayed as disabled. #130

Closed vlandham closed 8 years ago

vlandham commented 8 years ago
screen shot 2016-06-03 at 8 16 39 am screen shot 2016-06-03 at 8 16 55 am
vlandham commented 8 years ago

ping @pbeshai

vlandham commented 8 years ago

i believe the sort order should put disabled values at the bottom. Right now the sort order is purely based on value. But i would like to confirm with HMS first before making this change.

pbeshai commented 8 years ago

In their mockups the ones below the threshold are sorted to the bottom as if they had the lowest possible number.

vlandham commented 8 years ago

yeah. just the particulars changed pretty rapidly over the course of the day when we discussed.

I've updated with a new sort that does (i believe) what liz suggested in slack.

screen shot 2016-06-03 at 9 04 06 am