search

sorgerlab / CancerBrowser

HMS LINCS Cancer Browser
5 stars 3 forks source link

Bug - sort on waterfall chart should sort by ID if values are equal #133

Closed pbeshai closed 8 years ago

pbeshai commented 8 years ago

Prevents names shifting around on hover

vlandham commented 8 years ago

interesting. i thought i fixed that. must be missing another check

On Fri, Jun 3, 2016 at 12:52 PM, Peter Beshai notifications@github.com wrote:

Prevents names shifting around on hover

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bocoup/CancerBrowser/issues/133, or mute the thread https://github.com/notifications/unsubscribe/AAAkmfdobXZeggyv3ViaW37HSX2f0GM3ks5qIIXwgaJpZM4It2rG .

vlandham commented 8 years ago

we can also pass in additional sorts, if needed

On Fri, Jun 3, 2016 at 12:53 PM, Jim Vallandingham jim@bocoup.com wrote:

interesting. i thought i fixed that. must be missing another check

On Fri, Jun 3, 2016 at 12:52 PM, Peter Beshai notifications@github.com wrote:

Prevents names shifting around on hover

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bocoup/CancerBrowser/issues/133, or mute the thread https://github.com/notifications/unsubscribe/AAAkmfdobXZeggyv3ViaW37HSX2f0GM3ks5qIIXwgaJpZM4It2rG .

pbeshai commented 8 years ago

After #184 is done, we should switch the other pages to also using:

magnitude: sortByKeys(['-value', 'label']),

Unless they need to have disabled considered (receptor profiling only), in which case we should fix that.