search

sorgerlab / CancerBrowser

HMS LINCS Cancer Browser
5 stars 3 forks source link

Add :entityId as optional parameter to dataset landing pages #183

Closed vlandham closed 8 years ago

vlandham commented 8 years ago

This allows for communicating from browsing pages to dataset pages about what entity (drug or cell line) was clicked to get to the page.

The dataset page can then use that information to setup the page appropriately.

Both Drugs and Cell Line links should be updated with their entityId passing capabilities The Receptor page is updated to take advantage of this information in component did mount.

TODO:

vlandham commented 8 years ago

ping @pbeshai

pbeshai commented 8 years ago

I think we definitely need to pass in the viewBy parameter as well for cases like drug dose response where you have both view by cell line and view by drug

vlandham commented 8 years ago

ok. would you rather it be a :viewBy or a :entityType ? the former is more directive, the later more "informative" to provide info to the page to have it do what it wants with it.

pbeshai commented 8 years ago

let's try entityType. Will these URL params also update when views/toggles after navigating to a page?

vlandham commented 8 years ago

thats a good question.

at the moment, i was planning on encoding the sortby / viewby parameters more like the filters parameters

This would clobber the entityType / entityId values in the url - with the idea that the user is moving away from the initial view - and on to a customized view.

we could persist entityId and viewBy in the url - but it seems like it would be more bespoke and have to happen at the individual page level instead of the basepage...

On Wed, Jun 8, 2016 at 8:48 AM, Peter Beshai notifications@github.com wrote:

let's try entityType. Will these URL params also update when views/toggles after navigating to a page?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bocoup/CancerBrowser/pull/183#issuecomment-224633407, or mute the thread https://github.com/notifications/unsubscribe/AAAkmT067iaM4fYob230hpXPmEj1HG1Dks5qJuRegaJpZM4IxFzV .