sorgerlab / CancerBrowser

HMS LINCS Cancer Browser
5 stars 3 forks source link

Consistently handle "default values" for dataset pages #203

Closed pbeshai closed 8 years ago

pbeshai commented 8 years ago

Not clear currently if we want to have defaults or not. I think the result of our conversation with HMS was that we didn't want default values if they are coming straight from the dataset page, but to still support contextualized entry via entityId

vlandham commented 8 years ago

that is what i would like to propose as well.

if we have an :entityId / :entityType we show the best display we can on initial page load.

If this is not present, we show no defaults - but ensure we have explanatory text to encourage user interaction.

On leaving dataset page, we clear filters and reset to initial state.

On toggling of viewBy, we do not reset filters - but maintain both during the duration of time on the page.

Another optional level of refinement:

On toggling of viewBy - if we have not been to that viewBy before and we have selected an entity (i.e. cell type / receptor) on the previous viewBy, then we use this selected entity to inform the presentation of data.

On Thu, Jun 9, 2016 at 7:08 AM, Peter Beshai notifications@github.com wrote:

Not clear currently if we want to have defaults or not. I think the result of our conversation with HMS was that we didn't want default values if they are coming straight from the dataset page, but to still support contextualized entry via entityId

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bocoup/CancerBrowser/issues/203, or mute the thread https://github.com/notifications/unsubscribe/AAAkmUHIxMCFuqZI5p7mCXuKAtT2mkQxks5qKB5bgaJpZM4IyAv8 .

vlandham commented 8 years ago

done in #211