sorgerlab / bioagents

Biological reasoning agents
BSD 2-Clause "Simplified" License
5 stars 15 forks source link

MRA misinterprets correct looking EKB #41

Closed bgyori closed 7 years ago

bgyori commented 7 years ago

This could be an issue in the EKB agent or it could be an issue in INDRA's TRIPS processor. Either way, this is incorrect:

(REQUEST :CONTENT (BUILD-MODEL :DESCRIPTION "<ekb timestamp=\"20170829T123202\">
  <EVENT id=\"V81361\">
    <type>ONT::BIND</type>
    <force>ONT::TRUE</force>
    <arg id=\"V81353\" role=\":AFFECTED\"/>
    <arg id=\"V81407\" role=\":AFFECTED1\"/>
  </EVENT>
  <TERM id=\"V81353\" dbid=\"UP:P79800|UP:Q9YH38|HGNC:6407|XFAM:PF00071|UP:Q05147|UP:O42277|NCIT:C17383|UP:Q5EFX7|UP:P01116|NCIT:C16766\">
    <type>ONT::GENE-PROTEIN</type>
    <name>KRAS</name>
    <features>
      <inevent id=\"V81361\"/>
    </features>
    <drum-terms>
      <drum-term name=\"KRAS proto-oncogene, GTPase\" matched-name=\"KRAS\" match-score=\"1.0\" dbid=\"HGNC:6407\">
        <types>
          <type>ONT::GENE</type>
        </types>
        <xrefs>
          <xref dbid=\"UP:P01116\"/>
        </xrefs>
      </drum-term>
      <drum-term dbid=\"NCIT:C16766\" matched-name=\"KRAS\" name=\"oncogene K-ras\" match-score=\"0.82857\">
        <types>
          <type>ONT::GENE</type>
        </types>
      </drum-term>
      <drum-term dbid=\"NCIT:C17383\" matched-name=\"KRAS\" name=\"p21 K-ras protein\" match-score=\"0.82857\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
      </drum-term>
      <drum-term match-score=\"0.6528\" matched-name=\"K-ras\" name=\"GTPase KRas\" dbid=\"UP:Q9YH38\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
        <xrefs>
          <xref dbid=\"XFAM:PF00071\"/>
        </xrefs>
      </drum-term>
      <drum-term name=\"GTPase KRas\" matched-name=\"K-ras\" match-score=\"0.6528\" dbid=\"UP:Q5EFX7\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
        <xrefs>
          <xref dbid=\"XFAM:PF00071\"/>
        </xrefs>
      </drum-term>
      <drum-term dbid=\"UP:P79800\" name=\"GTPase KRas\" matched-name=\"K-ras\" match-score=\"0.6528\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
        <xrefs>
          <xref dbid=\"XFAM:PF00071\"/>
        </xrefs>
      </drum-term>
      <drum-term match-score=\"0.6528\" matched-name=\"K-ras\" name=\"GTPase KRas\" dbid=\"UP:O42277\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
        <xrefs>
          <xref dbid=\"XFAM:PF00071\"/>
        </xrefs>
      </drum-term>
      <drum-term dbid=\"UP:Q05147\" match-score=\"0.6528\" matched-name=\"K-ras\" name=\"GTPase KRas\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
        <xrefs>
          <xref dbid=\"XFAM:PF00071\"/>
        </xrefs>
      </drum-term>
    </drum-terms>
  </TERM>
  <TERM id=\"V81407\" dbid=\"CHEBI:37565|CHEBI:15996\">
    <type>ONT::MOLECULE</type>
    <name>GTP</name>
    <drum-terms>
      <drum-term match-score=\"1.0\" name=\"GTP\" matched-name=\"GTP\" dbid=\"CHEBI:15996\">
        <types>
          <type>ONT::CHEMICAL</type>
          <type>ONT::MOLECULE</type>
        </types>
      </drum-term>
      <drum-term match-score=\"0.6387\" matched-name=\"gtp\" name=\"GTP(4-)\" dbid=\"CHEBI:37565\">
        <types>
          <type>ONT::CHEMICAL</type>
          <type>ONT::MOLECULE</type>
        </types>
      </drum-term>
    </drum-terms>
  </TERM>
  <EVENT id=\"V81412\">
    <type>ONT::PHOSPHORYLATION</type>
    <force>ONT::TRUE</force>
    <arg role=\":AGENT\" id=\"V81353\"/>
    <arg id=\"V81417\" role=\":AFFECTED\"/>
    <site id=\"V81464\"/>
    <drum-terms>
      <drum-term dbid=\"GO:0006468\" match-score=\"1.0\" name=\"protein phosphorylation\" matched-name=\"protein phosphorylation\">
        <types>
          <type>ONT::POST-TRANSLATIONAL-MODIFICATION</type>
        </types>
      </drum-term>
    </drum-terms>
  </EVENT>
  <TERM id=\"V81417\" dbid=\"NCIT:C17476|HGNC:1097|NCIT:C51194|UP:P15056\">
    <type>ONT::GENE-PROTEIN</type>
    <name>BRAF</name>
    <drum-terms>
      <drum-term match-score=\"1.0\" matched-name=\"BRAF\" name=\"B-Raf proto-oncogene, serine/threonine kinase\" dbid=\"HGNC:1097\">
        <types>
          <type>ONT::GENE</type>
        </types>
        <xrefs>
          <xref dbid=\"UP:P15056\"/>
        </xrefs>
      </drum-term>
      <drum-term dbid=\"NCIT:C51194\" match-score=\"1.0\" matched-name=\"BRAF\" name=\"BRAF\">
        <types>
          <type>ONT::GENE</type>
        </types>
      </drum-term>
      <drum-term name=\"B-RAF protein kinase\" matched-name=\"BRAF\" match-score=\"0.82857\" dbid=\"NCIT:C17476\">
        <types>
          <type>ONT::PROTEIN</type>
        </types>
      </drum-term>
    </drum-terms>
  </TERM>
  <TERM id=\"V81464\">
    <type>ONT::MOLECULAR-SITE</type>
    <name>T-373</name>
    <features>
      <site>
        <name>Threonine</name>
        <code>T</code>
        <pos>373</pos>
      </site>
    </features>
  </TERM>
</ekb>") :REPLY-WITH BUILD-MODEL-854 :sender BA)

From MRA:
(reply :content (SUCCESS :model-id 8 :model "[{\"type\": \"Complex\", \"members\": [{\"name\": \"KRAS\", \"db_refs\": {\"TEXT\": \"KRAS\", \"HGNC\": \"6407\", \"UP\": \"P01116\", \"NCIT\": \"C17383\"}}, {\"name\": \"GTP\", \"db_refs\": {\"TEXT\": \"GTP\", \"CHEBI\": \"CHEBI:15996\"}}], \"evidence\": [{\"source_api\": \"trips\"}], \"id\": \"77e4e859-767d-433a-bc06-c54988264e1f\", \"sbo_definition\": \"http://identifiers.org/sbo/SBO:0000526\"}, {\"type\": \"Phosphorylation\", \"enz\": {\"name\": \"KRAS\", \"db_refs\": {\"TEXT\": \"KRAS\", \"HGNC\": \"6407\", \"UP\": \"P01116\", \"NCIT\": \"C17383\"}, \"sbo_definition\": \"http://identifiers.org/sbo/SBO:0000460\"}, \"sub\": {\"name\": \"BRAF\", \"db_refs\": {\"TEXT\": \"BRAF\", \"HGNC\": \"1097\", \"UP\": \"P15056\", \"NCIT\": \"C17476\"}, \"sbo_definition\": \"http://identifiers.org/sbo/SBO:0000015\"}, \"residue\": \"T\", \"position\": \"373\", \"evidence\": [{\"source_api\": \"trips\"}], \"id\": \"63a1a78e-89fa-499f-bbfe-e66d0c55619d\", \"sbo_definition\": \"http://identifiers.org/sbo/SBO:0000216\"}]" :diagram "/home/bmg16/src/cwc-integ/hms/bioagents/model8_rxn.png") :receiver BA :in-reply-to BUILD-MODEL-854 :sender MRA)
bgyori commented 7 years ago

This is fixed via INDRA but should be tested for regressions.

bgyori commented 7 years ago

Done in 1c1bdb67aa21a4e51844107c4ab9053e82fde897