sorgerlab / indra

INDRA (Integrated Network and Dynamical Reasoning Assembler) is an automated model assembly system interfacing with NLP systems and databases to collect knowledge, and through a process of assembly, produce causal graphs and dynamical models.
http://indra.bio
BSD 2-Clause "Simplified" License
171 stars 65 forks source link

Flask>=3 requires changes to flask-jwt-extended usage #1448

Closed kkaris closed 1 month ago

kkaris commented 2 months ago

Upgrading to Flask>=3,<4 comes with a second order consequence: currently we use flask-jwt-extended<4, which requires Flask<2.0,>=1.0. However, upgrading flask-jwt-extended to be compatible with Flask>=3,<4 comes with an api change documented here: https://flask-jwt-extended.readthedocs.io/en/stable/v4_upgrade_guide.html#api-changes

In short, we need to replace all instances of the decorator @jwt_optional with @jwt_required(optional=True) wherever we update to Flask>=3,<4.

Related: https://github.com/gyorilab/gilda/issues/137

I'll try to list all places in downstream repositories in sorger/gyorilab where we would need to make the change:

To test the upgrade

Testing

kkaris commented 1 month ago

Remaining things: