search

sorich87 / bootstrap-tour

Quick and easy product tours with Twitter Bootstrap Popovers
http://bootstraptour.com
MIT License
4.44k stars 941 forks source link

Backdrop with incorrect height causes overflow in Firefox when the page is loaded #136

Closed cilia closed 11 years ago

cilia commented 11 years ago

This seems to happen only in Firefox (tested on latest).

Whenever a page (with tour steps initialized on load and all with backdrop) is loaded, the very first step gets a wrong height for the backdrop, for example:

<div class="tour-backdrop" style="height: 710px;"></div>

But the whole body's height is only 630px. This will cause a blank space at the bottom of the page and the vertical scrollbar will appear.

Strangely enough, as soon as I click 'Prev' or 'Next', the height of the backdrop gets re-calculated correctly, which fixes the problem.

Why does this happen? Safari and Chrome both work fine.

LostCrew commented 11 years ago

hi cilia,

thanks for your feedback. i'll investigate on this today. i get back at you soon.

LostCrew commented 11 years ago

@cilia we're gonna integrate the fix in 0.6.1. pull it as soon as we release it. thanks again.

cilia commented 11 years ago

Great stuff! Thanks a lot @LostCrew !