search

sorich87 / bootstrap-tour

Quick and easy product tours with Twitter Bootstrap Popovers
http://bootstraptour.com
MIT License
4.44k stars 942 forks source link

Add keyboard option to enable/disable keyboard navigation and ESC to end tour #70

Closed sorich87 closed 11 years ago

LostCrew commented 11 years ago

@sorich87 sorry but i don't understand. can you explain me?

sorich87 commented 11 years ago

I meant we should make the tour end when the user press escape key and add an option called 'keyboard' (true by default) to disable all the keyboard bindings (like the keyboard option of Bootstrap Modal).

LostCrew commented 11 years ago

we already have a keyboard option. i only add the event handler attached to ESC key if keyboard is true.

dstapp commented 6 years ago

In the current version 0.12.0 with keyboard: true, closing the tour with ESC seems not to work. Was this ever implemented?

vanderlee commented 6 years ago

See PR #656. It was easy enough to fix in JS, but this project uses coffeescript.