sorin-ionescu / prezto

The configuration framework for Zsh
MIT License
13.98k stars 4.49k forks source link

Add github topics to the repo? #1950

Closed jeffwidman closed 2 years ago

jeffwidman commented 3 years ago

We aren't listed in https://github.com/topics/zsh-configuration or https://github.com/topics/zsh-frameworks or similar.

I tried to add these, but appears only the repo admin can do it, collaborators don't have enough permissions.

mattmc3 commented 2 years ago

@belak - This would be a quick one to resolve. Below are screen grabs of the topics that OMZ and ZIM use in their repos:

Screen Shot 2022-02-15 at 6 20 35 PM Screen Shot 2022-02-15 at 6 20 05 PM
belak commented 2 years ago

I would add these if I could. Unfortunately, Sorin never added another admin, only collaborators, so while I have push access I can't make any repo changes like tags or additional collaborators.

srijanshetty commented 2 years ago

Would it be okay to reach out to GitHub for escalation of rights?

belak commented 2 years ago

We could ask GitHub support, but it seems unlikely they'd grant such a request. Giving someone else admin over a repo they don't own is no joke - the best bet would be to fork, show that your repo is the actively maintained "primary fork" or a sort of "blessed replacement" by updating the readme of the original repo and asking them to change the "primary repo" for prezto so other forks point there.

mattmc3 commented 2 years ago

I noticed that @sorin-ionescu hasn't committed to GitHub in years, but is he totally MIA? He tweets from time to time. Would we be able to ask for Prezto to move to its own org similar to how Robby Russell moved OMZ out of his personal repo to ohmyzsh/ohmyzsh? That would allow redirections to work for old references, and would then allow those of us invested in carrying on Prezto to continue to grow the project as a community driven endeavor.

mattmc3 commented 2 years ago

Looks like this has turned into a callback discussion from 2017 here: https://github.com/sorin-ionescu/prezto/issues/1284#issuecomment-314181416

Now that it's 2022, are we able to revisit and make it happen, or are there still barriers to moving it to zsh-users?

belak commented 2 years ago

Now that it's 2022, are we able to revisit and make it happen, or are there still barriers to moving it to zsh-users?

It's unfortunately the same as before - we need Sorin to do the move (and I'm not sure if he's around) and I think it's still @nicoulaj for approval going into zsh-users. I'd be happy to lead the project if there was a bit more freedom, but it might result in some larger (possibly breaking) changes long term (since I have some restructuring/features in mind).

belak commented 2 years ago

The other option would be a hard fork with a new direction and leaving a message in the readme here. That would be far more realistic.

srijanshetty commented 2 years ago

I've message @sorin-ionescu on Twitter and I hope he responds.

srijanshetty commented 2 years ago

@belak I was able to speak to sorin and he is looking into the permissions.

sorin-ionescu commented 2 years ago

Hello, lads. I do not see the option to add additional administrators. The interface only allows me to invite users to become collaborators and to delete collaborators. This may be a limitation of a personal account, or my account specifically. Perhaps, I need to upgrade my account?

There is a button at the bottom to create an organization.

I would have preferred to keep the project under my account to not disturb the existing URLs, with the option to add a successor, but that may not be possible due to the current account limitations. In that case, is it preferable for you, collaborators, that I create a new Prezto organization or for Prezto to join an existing one, such as zsh-users? I am one of the owners. It may affect the visibility of the project.

belak commented 2 years ago

Thanks for looking into this!

I wasn't super familiar with the differences, but according to the GitHub docs it looks like you can't add other admins to a repo unless it's in an org.

It would be nice to have it in an org and I think it's worth the trade-offs. Additionally, if you transfer the repo and don't create a new one with the name prezto, the current location will redirect to the new location.

Either zsh-users or a separate org would work for me - there's also the prezto-contrib repo and it might be nice to move external prompts to a prezto-prompts repo (or something similar). Having those all in one place would be nice.

mattmc3 commented 2 years ago

I think that the fact that https://github.com/robbyrussell/oh-my-zsh properly redirects to https://github.com/ohmyzsh/ohmyzsh shows how this is a non-breaking change, unless, as belak metioned, you ever create another Prezto repo under your account. It also bears mentioning that you could accidentally do this if you ever fork the new primary home to make a change. Github doesn't really warn you that you're about to nuke a redirect. For this reason, it might be good for you to be an admin wherever this lands so that forking is never necessary for you to make code changes.

Also, it appears that the https://github.com/prezto org exists already. I'm hoping that's yours @sorin-ionescu or else moving it there would be a bad idea. Is there someone from zsh-users we need to "at" into this convo so that they can speak to their end of getting this set up if a transfer is initiated?

sorin-ionescu commented 2 years ago

@mattmc3 The Prezto organization is not mine. I do not know who has created it nor when. It has no public members nor repositories. It may be never used and abandoned. @github support will have to be contacted to see if it can be repurposed for our needs.

In the case of zsh-users, I am one of the owners. Thus, I do not believe that I have to bother anyone to move Prezto there.

srijanshetty commented 2 years ago

Moving it to zsh-users would be the best option while keeping the redirect.

srijanshetty commented 2 years ago

@sorin-ionescu could you just add the tags and we could then close this issue :)

sorin-ionescu commented 2 years ago

I'll add them.

On the subject of admins, if I could add them, I would. Only organisations can have multiple admins.

sorin-ionescu commented 2 years ago

I've added some. If you want more, type them here.