search

sorintlab / stolon

PostgreSQL cloud native High Availability and more.
https://talk.stolon.io
Apache License 2.0
4.62k stars 444 forks source link

Migrate etcd to use 'etcd-io/etcd' and update relevant paths #838

Open davissp14 opened 3 years ago

davissp14 commented 3 years ago

Given the coreos/etcd client was deprecated back in 2015, let's work to move to etcd-io/etcd.

davissp14 commented 3 years ago

make tests in Agola are failing with:

panic: codecgen version mismatch: current: 8, need 10. Re-generate file: /go/pkg/mod/github.com/coreos/etcd@v3.3.10+incompatible/client/keys.generated.go
goroutine 1 [running]:

Not quite sure what to do about that. Tests work fine locally.

sgotti commented 3 years ago

@davissp14 Thanks for the PR. Sorry but I don't understand the title and why this is needed. We're already using for etcdv3 go.etcd.io/etcd client v3, just the 3.4 version with a workaround since only from the recently released etcd v3.5 they fixed the wrong module path (missing /v3). github.com/coreos/etcd is used for etcdv2 and required by libkv.

davissp14 commented 3 years ago

@sgotti My mistake, the dependencies here are a little confusing... For context, I have a fork where i'm introducing the ability to specify Store specific credentials for Etcd. I was not able to get authentication to work properly using the current client version. Bumping to 3.5 seems to have addressed my issues.