search

soroswap / aggregator

Soroswap Aggregator and Adapters Smart Contracts. Includes Soroswap.Finance and Phoenix Adapters
https://soroswap.finance
Apache License 2.0
2 stars 1 forks source link

1 Separate initialize from the soroswap-aggregator-adapter-interface #36

Open joaquinsoza opened 4 months ago

joaquinsoza commented 4 months ago

Separate initialize from the soroswap-aggregator-adapter-interface and add it as a independent trait inside the adapter

Why? In the future another adapter could need more initialization options and we will be held back by the adapter-interface, so i think is better for us to take out the initialize from the interface trait and define it as a separate Trait inside the adapter.

An example can be found in the DeFindex adapters

esteblock commented 2 months ago

Please comment with Runtime Verification before addressing this issue.

esteblock commented 2 months ago

Or use a vec of values...