soroswap / frontend

Soroswap.Finance Frontend for Soroswap AMM, Soroswap Aggregator & Spacewalk Bridge Implementation
https://soroswap.finance
MIT License
6 stars 10 forks source link

Fix bugs with slippage settings and improve user experience #342

Closed the-syndrome closed 7 months ago

the-syndrome commented 7 months ago

After talking with @esteblock I saw he wants to emulate more closely the slippage config on Uniswap. This change accomplishes that and goes a little further making it easier for the user.

FYI: It depends on my previous PR which I accidentally left in the main branch.

Before

Previously when it opened the first time it was expanded and the wrong text.

first-open-before

Compare with Uniswap

https://github.com/soroswap/frontend/assets/165131835/e4c928e0-8d1b-4f0b-9b39-8f194bcaee13

After

https://github.com/soroswap/frontend/assets/165131835/ec22d858-9937-400f-98d8-cf1f67e00980


Specific details

vercel[bot] commented 7 months ago

@the-syndrome is attempting to deploy a commit to the Soroswap Team on Vercel.

A member of the Team first needs to authorize it.

the-syndrome commented 7 months ago

As an aside I couldn't figure out how to get the placeholder to dim like on other text boxes. Maybe someone can show me?

abstract829 commented 7 months ago

good work