soroswap / frontend

Soroswap.Finance Frontend for Soroswap AMM, Soroswap Aggregator & Spacewalk Bridge Implementation
https://soroswap.finance
MIT License
4 stars 9 forks source link

Fix/minimum xlm value #344

Closed benjaguiloff closed 5 months ago

benjaguiloff commented 5 months ago
vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 6:29pm
esteblock commented 5 months ago

@chopan123 @joaquinsoza
Another 2 problems here are: 1) Currently:

Proposed:

2) Because starts calculating fees straight away, and does not waints until it's an accepted trade, it calculates fees with 0 output amount, having the RouterInsufficientOutputAmount = 507, error allways

Error fetching network fees: Error: host invocation failed
Caused by:
    HostError: Error(Contract, #507)
esteblock commented 5 months ago

@MattPoblete https://github.com/soroswap/frontend/issues/304

chopan123 commented 5 months ago
  • Dapp waits you to put an amount in order to simulate the tx and know the txfees.

  • then when you press MAX, it calcualtes again and so on, infinite loop

moved to issues #359 and #358

chopan123 commented 5 months ago

New PR on #360