search

soroswap / info

Analytics site for Soroswap
https://info.soroswap.finance
GNU General Public License v3.0
3 stars 8 forks source link

Show Liquidty Providers in Pool Level #78

Open esteblock opened 1 month ago

esteblock commented 1 month ago

In Pool page, add tab called "Liquidity Providers" Show "Account (with link to address in stellar expert)", "TVL", "Pool share"

omsant02 commented 3 weeks ago

i would like to take this issue @esteblock

would solve this by adding a new column "Liquidity Providers" in the pool page

esteblock commented 3 weeks ago

i would like to take this issue @esteblock

would solve this by adding a new column "Liquidity Providers" in the pool page

Hello @omsant02 I have not seen any draft PR. Do you hav something? If not, I will assign other dev. If you have any question please reach on Discord https://discord.com/invite/G8c98rhfqw

omsant02 commented 3 weeks ago

hey i'm working on the issue, most probably by tonight i'll raise the pr

esteblock commented 3 weeks ago

hey i'm working on the issue, most probably by tonight i'll raise the pr

I want to see your progress as a draft PR please, otherwise it will be considered as not developed

omsant02 commented 3 weeks ago

yep i understand, please give me some time, i'm currently outside of my home, will raise pr as soon as i get back

esteblock commented 2 weeks ago

Hello @omsant02 the PR is not ready, I will asign someone else

omsant02 commented 2 weeks ago

hi @esteblock ,

i was also working on issue # 81 and there i have raised the final pr and also asked you for a review,

i thought first we would be finalising issue #81 and then we would go for this issue

omsant02 commented 2 weeks ago

can you please look the issue #81 and the pr i have raised for it, i think after #81 it will be eaisy for me to complete this issue, and it's a request please let me complete this issue

esteblock commented 2 weeks ago

can you please look the issue #81 and the pr i have raised for it, i think after #81 it will be eaisy for me to complete this issue, and it's a request please let me complete this issue

81 was quite easy, what about this one?

omsant02 commented 2 weeks ago

yep thanks for merging it, issue #78 will be completed by the end of the day

omsant02 commented 2 weeks ago

hi @esteblock the pr is ready, please review it thanks

esteblock commented 1 week ago

@omsant02 I pulled your PR into a new branch as a draft PR so we can continue from there https://github.com/soroswap/info/pull/87

I will close your PR, as it is not complete and I will unasgin you until we get someone that can edit the indexer in https://github.com/soroswap/zephyr-programs so we can get a list of liquidity providers

However, thanks for your contribution!

Check discussion in https://github.com/soroswap/info/pull/84

omsant02 commented 1 week ago

yep, thanks

esteblock commented 1 week ago

First lets finish https://github.com/soroswap/zephyr-programs/issues/37