soroswap / info

Analytics site for Soroswap
https://info.soroswap.finance
GNU General Public License v3.0
3 stars 5 forks source link

Bug: Volume is considering volume through add and remove liquidity, should only be swap volume #79

Open esteblock opened 2 weeks ago

suhas-sensei commented 1 week ago

i want to tackle this, having experience in this regard. i will volume calculation from addLiquidity and removeLiquidity functions and keep volume tracking only in swap function, ensuring it captures only the actual trading volume. then i will update the volume metric to track only the value of tokens being swapped directly through the swap function. now since not much description is provided, im unsure whether to track volume in terms of token0 or token1's value, or if it needs to be converted to a standard unit (like USD) for consistency across different pairs.

martinvibes commented 1 week ago

Can I tackle this one? kindly assign :)

NueloSE commented 1 week ago

Is this issue still available? I would like to contribute to it kindly assign me

Jemiiah commented 1 week ago

@esteblock pls could I be assigned this issue here's my onlydust profile : https://github.com/Jemiiah ETA : 48 hours

tasneemtoolba commented 1 week ago

I’d love to work on this task.

PoulavBhowmick03 commented 1 week ago

May I take this issue on? I'm Poulav Bhowmick, a Starknet Wolf. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum, Stellar ecosystem.

I would go through the code, look at the bug and try to fix this

ETA - 1 day

ikemHood commented 1 week ago

Hey @esteblock, can I jump on this,

I would figure where the volume logic was written and what is not acting as expected, the. Rewrite that to fix the volume.

ETA: 24hrs

aniruddhaaps commented 1 week ago

I'm a javascript dev, a new comer here. I want to take the issue and solve it.

0xdevcollins commented 1 week ago

Can I contribute to this one?

Kaminar-i commented 1 week ago

Is it okay if I take this?

Benjtalkshow commented 1 week ago

Hey @esteblock I can easily fix this issue. It will take me 24hrs max. Thanks.

sigmadawg commented 1 week ago

im a newbie contributor, i'd be grateful if you'd give me the opportunity to work in this.

Josh-121 commented 1 week ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

software engineering background, backend & smart contract dev(https://app.onlydust.com/u/Josh-121) looking to make first contribution on this project

How I plan on tackling this issue

  1. Filter Transaction Types: Update the volume calculation logic to distinguish between swap transactions and add/remove liquidity events. The function will filter for swap events exclusively.
  2. Refactor Existing Code: Adjust any related functions and data models to ensure only swap transactions are counted toward the volume metric, leaving add/remove liquidity events untouched. work on feedback & recommendation ensuring contact. Can deliver within a day
suhas-sensei commented 1 week ago

@esteblock thank you for assigning me

esteblock commented 6 days ago

@esteblock thank you for assigning me Hello @suhas-sensei I have not seen any draft PR. Do you have something? If not, I will assign other dev. If you have any question please reach on Discord https://discord.com/invite/G8c98rhfqw

suhas-sensei commented 6 days ago

@esteblock yes I tried reaching you out but telegram was off, sending a draft i 6hrs

esteblock commented 3 days ago

@esteblock yes I tried reaching you out but telegram was off, sending a draft i 6hrs

Hello Sorry, We are only available on Discord. I will check your PR now

esteblock commented 3 days ago

There is an error in your PR, please fix @suhas-sensei

esteblock commented 1 day ago

Hello @suhas-sensei ?