Wrong screenshot driver recommended for s3 storage setup

sorry-cypress / charts

A Kubernetes Helm Chart for Sorry Cypress, an open-source on-premise, self-hosted alternative to cypress dashboard.

https://sorry-cypress.dev

MIT License

42 stars 79 forks source link

Wrong screenshot driver recommended for s3 storage setup #199

Closed jwohlfahrt closed 1 year ago

jwohlfahrt commented 1 year ago

Summary

Sorry cypress chart README docs mention if you are using s3 storage setup that you should use the mino screenshot driver, but seems like this is a typo, and the s3 screenshot driver should be recommended, unless I'm mistaken.

How to reproduce

The readme docs in question can be found here.

Environment

sorry-cypress version: 2.4.2
cypress version: 12.5.0
helm chart version: 1.9.0

fbritoferreira commented 1 year ago

@jwohlfahrt Could you create a pr to fix this?

jwohlfahrt commented 1 year ago

@fbritoferreira for sure!