sorry-cypress / charts

A Kubernetes Helm Chart for Sorry Cypress, an open-source on-premise, self-hosted alternative to cypress dashboard.
https://sorry-cypress.dev
MIT License
42 stars 79 forks source link

feat: allow setting record keys from existing Kubernetes secret #200

Closed aridelsante closed 1 year ago

aridelsante commented 1 year ago

Thank you for offering a contribution to the Sorry Cypress Helm charts.

In order to ensure some level of quality, there are a few hoops to jump through. Please do not create a Pull Request until you have performed all these steps:

Checklist:

fbritoferreira commented 1 year ago

@aridelsante looks like your change is failing on CI could you take at look at fixing the tests?

aridelsante commented 1 year ago

@aridelsante looks like your change is failing on CI could you take at look at fixing the tests?

@fbritoferreira I've run those exact checks from my fork (disabling fail-fast for convenience) and they are successful after retrying some of them.

Have you perhaps also noticed those tests being flaky overall?

fbritoferreira commented 1 year ago

@aridelsante I notice this on my own branch, I will try and get some time today to fix it

fbritoferreira commented 1 year ago

@aridelsante If you go ahead and fix the conflicts I will merge it once its done

aridelsante commented 1 year ago

Apologies for the delay @fbritoferreira, the conflicts are now resolved! Thank you!

apeduru-patreon commented 1 year ago

Can this be merged in yet? Would love to start using this as opposed to writing out the record keys in cleartext.