sorry-cypress / charts

A Kubernetes Helm Chart for Sorry Cypress, an open-source on-premise, self-hosted alternative to cypress dashboard.
https://sorry-cypress.dev
MIT License
42 stars 79 forks source link

s3 URL is wrong in sorry-cypress dashboard #224

Open thowd22 opened 1 year ago

thowd22 commented 1 year ago

Before opening, please confirm:

Environment information

``` - sorry-cypress version: `latest` - cypress version: `latest` - cy2 version: `latest` - platform: `k8s` - service: `dashboard` ```

Describe the bug

It seems like the url for viewing screenshots is hard-coded in sorry-cypress dashboard. We are uploading to an s3 bucket in gov cloud and the url is incorrect for viewing the screenshots.

This is the correct bucket url: https://company-cypress-tests.s3-us-gov-east-1.amazonaws.com This is the url in the dashboard: https://company-cypress-tests.s3.amazonaws.com

Maybe its an issue with the s3 driver?

Expected behavior

Screenshots are viewable in the dashboard.

Reproduction steps

Set region: us-gov-east-1 in the sorry-cypress helm chart.

Full log and debug output

``` // Put your logs below this line ```
agoldis commented 1 year ago

Check out: https://docs.sorry-cypress.dev/configuration/director-configuration/aws-s3-configuration S3_READ_URL_PREFIX

thowd22 commented 1 year ago

Do I change that option in the chart to? Will it change the url for previous builds?

readUrlPrefix: "company-cypress-tests.s3-us-gov-east-1.amazonaws.com"

agoldis commented 1 year ago

@thowd22 not sure - maybe @fbritoferreira can help

fbritoferreira commented 1 year ago

@thowd22 Are you using the chart? If so can you please share your config

chrishollandaise commented 1 year ago

From testing, changing the readUrlPrefix will not be reflected in previous builds. If it pointed to the wrong resource, it will won't change after proper configurations.