search

sorvani / freepbx-helper-scripts

Assorted scripts and files that work with FreePBX
GNU General Public License v3.0
71 stars 27 forks source link

Main foreach loop simplification #20

Closed drcoccodrillus closed 1 year ago

drcoccodrillus commented 1 year ago

I bumped into your repo while I was looking for a solution for generating XML address book for Yealink phones. Thank you, it's a very nice script! However, I have simplified the foreach loop logic. I tested on my FreePBX instances and it works fine. Have a look at it and let me know.

sorvani commented 1 year ago

i am out of town. I will look at it later this week. thanks for the PR

drcoccodrillus commented 1 year ago

No worries! Take your time mate.

drcoccodrillus commented 1 year ago

Hi mate! Did you get a chance for reviewing the pull request?

sorvani commented 1 year ago

Finally had a chance to test this. Thanks for the submission.