search

sos-os / alarm

ALARM: Another Library for Allocating and Releasing Memory
Apache License 2.0
8 stars 6 forks source link

Feat/intrusive singly linked list #35

Closed amanjeev closed 6 years ago

amanjeev commented 6 years ago

Implements https://github.com/hawkw/alarm/issues/8

hawkw commented 6 years ago

Yay! I'll review this as soon as I have a chance! 🎉

amanjeev commented 6 years ago

I am about to push the changes you suggested. Is it ok to push all the above changes in the review in one single commit?

hawkw commented 6 years ago

@amanjeev go for it, i think we'll probably want to squash this branch into 1-2 commits before merging anyway!

amanjeev commented 6 years ago

@hawkw - you are blazing fast! 😄

amanjeev commented 6 years ago

I have pushed the changes. Logging off for the night. Will see requests tomorrow, if any. Thank you.

Also, i would like to take another task if it’s ok with you after this.

hawkw commented 6 years ago

@amanjeev this looks great, I'm going to go ahead and merge. I can think of a few clear follow-up issues once this is on master, I'll open tickets if you're interested.